BPI/arm-trusted-firmware
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(css): fix SCP to AP shared memory address

Browse Source 
Commit 1e969d01a636 ("fix(build): use assignment instead of memcpy to
avoid a GCC 11 bug") introduced a shared_mem_ap_to_scp variable to
mitigate a compiler issue but mistakenly used that variable in the scpi
receive path, when it should obviously use the SCP to AP address
instead.

Introduce a similar shared_mem_scp_to_ap variable and use it instead.

Change-Id: Ib66ac4c791dc505a94f3d6c75b6196d246785360
Signed-off-by: Paul Kocialkowski <paulk@sys-base.io>
This commit is contained in:
Paul Kocialkowski 2026-05-19 21:51:00 +02:00 committed by Harrison Mutai
parent de387341ee
commit 221cf4b901
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/arm/css/scpi/css_scpi.c
View File

@ -19,6 +19,8 @@
#define SCPI_SHARED_MEM_AP_TO_SCP (PLAT_CSS_SCP_COM_SHARED_MEM_BASE \
+ 0x100)
static volatile scpi_cmd_t *shared_mem_scp_to_ap =
(volatile scpi_cmd_t *)SCPI_SHARED_MEM_SCP_TO_AP;
static volatile scpi_cmd_t *shared_mem_ap_to_scp =
(volatile scpi_cmd_t *)SCPI_SHARED_MEM_AP_TO_SCP;
@ -76,7 +78,7 @@ static int scpi_secure_message_receive(scpi_cmd_t *cmd)
*/
dmbld();
*cmd = *shared_mem_ap_to_scp;
*cmd = *shared_mem_scp_to_ap;
return 0;
}