Qubot/retro-go
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bumped minimum esp-idf version to 4.4

Browse Source 
Hopefully will be bumped to 5.0 before the next release but right now there are remaining issues.
This commit is contained in:
Alex Duchesne 2024-09-02 14:08:09 -04:00
parent 0bdd41512f
commit 51c90aae19
4 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
BUILDING.md
View File

@ -1,9 +1,9 @@
# Building Retro-Go
## Prerequisites
You will need a working installation of [esp-idf](https://docs.espressif.com/projects/esp-idf/en/release-v4.3/esp32/get-started/index.html#get-started-get-prerequisites). Versions 4.2 to 5.2 are supported.
You will need a working installation of [esp-idf](https://docs.espressif.com/projects/esp-idf/en/release-v4.4/esp32/get-started/index.html#get-started-get-prerequisites). Versions 4.4 to 5.2 are supported.
_Note: As of retro-go 1.35, I use 4.3. Version 4.1 was used for 1.20 to 1.34 versions._
_Note: As of retro-go 1.44, I use 4.4.8. I used 4.3 for 1.35 to 1.43. ESP-IDF 4.1 was used for 1.20 to 1.34 versions._
### ESP-IDF Patches
Patching esp-idf may be required for full functionality. Patches are located in `tools/patches` and can be applied to your global esp-idf installation, they will not break your other projects/devices.

2
Dockerfile
View File

@ -1,4 +1,4 @@
FROM espressif/idf:release-v4.3
FROM espressif/idf:release-v4.4
WORKDIR /app

2
components/retro-go/drivers/audio/i2s.c
View File

@ -67,9 +67,7 @@ static bool driver_init(int device, int sample_rate)
if (ret == ESP_OK)
{
ret = i2s_set_pin(I2S_NUM_0, &(i2s_pin_config_t) {
#if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(4, 4, 0)
.mck_io_num = GPIO_NUM_NC,
#endif
.bck_io_num = RG_GPIO_SND_I2S_BCK,
.ws_io_num = RG_GPIO_SND_I2S_WS,
.data_out_num = RG_GPIO_SND_I2S_DATA,

4
components/retro-go/rg_system.h
View File

@ -16,8 +16,8 @@ extern "C" {
#include <esp_idf_version.h>
#include <esp_heap_caps.h>
#include <esp_attr.h>
#if ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(4, 3, 0)
#error "Retro-Go requires ESP-IDF version 4.3.0 or newer!"
#if ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(4, 4, 0)
#error "Retro-Go requires ESP-IDF version 4.4.0 or newer!"
#endif
#else
#define IRAM_ATTR