Qubot/retro-go
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rg_system: Avoid unnecessary flash write in rg_system_switch_app

Browse Source 
Now that the launcher is part of retro-core, switching between it and most emulators means rebooting to the same partition.

esp_ota_set_boot_partition doesn't check if changes happened, it always overwrites the OTA data partition.

This patch checks if the current partition is ok, and if so do not call esp_ota_set_boot_partition.
This commit is contained in:
Alex Duchesne 2024-10-19 15:03:30 -04:00
parent 927c30f398
commit b64e4816a0
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
components/retro-go/rg_system.c
View File

@ -859,17 +859,24 @@ void rg_system_switch_app(const char *partition, const char *name, const char *a
rg_settings_commit();
}
#if defined(ESP_PLATFORM)
// Check if the OTA settings are already correct, and if so do not call esp_ota_set_boot_partition
// This is simply to avoid an unecessary flash write...
const esp_partition_t *current = esp_ota_get_boot_partition();
if (current && current->label && partition && strcmp(current->label, partition) == 0)
{
RG_LOGI("Boot partition already set to desired app!");
rg_system_restart();
}
esp_err_t err = esp_ota_set_boot_partition(esp_partition_find_first(
ESP_PARTITION_TYPE_APP, ESP_PARTITION_SUBTYPE_ANY, partition));
if (err != ESP_OK)
{
RG_LOGE("esp_ota_set_boot_partition returned 0x%02X!\n", err);
RG_LOGE("esp_ota_set_boot_partition returned 0x%02X!", err);
RG_PANIC("Unable to set boot app!");
}
#elif defined(RG_TARGET_SDL2)
// RG_PANIC("Not implemented");
#endif
rg_system_restart();
#endif
RG_PANIC("Switch not implemented!");
}
bool rg_system_have_app(const char *app)